[PATCH] D94223: [SelectionDAG] Extend immAll(Ones|Zeros)V to handle ISD::SPLAT_VECTOR

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 8 09:56:44 PST 2021


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/utils/TableGen/DAGISelMatcherGen.cpp:286
+      MVT VT = N->getSimpleType(0);
+      std::string Name =
+          VT.isScalableVector() ? "splat_vector" : "build_vector";
----------------
This can be a StringRef now. I fixed getSDNodeNamed yesterday.


================
Comment at: llvm/utils/TableGen/DAGISelMatcherGen.cpp:300
+      std::string Name =
+          VT.isScalableVector() ? "splat_vector" : "build_vector";
+      const SDNodeInfo &NI = CGP.getSDNodeInfo(CGP.getSDNodeNamed(Name));
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94223/new/

https://reviews.llvm.org/D94223



More information about the llvm-commits mailing list