[PATCH] D93042: [noalias.decl] Look through llvm.experimental.noalias.scope.decl

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

The changes here all look reasonable to me. Ideally we would add test cases for the individual passes and land this before changing inlining, such that the inlining change by itself does not cause undue regressions.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1751
+  case Intrinsic::experimental_noalias_scope_decl:
+    break;
   default: {
----------------
This doesn't do anything :)


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:2555
           case Intrinsic::objectsize:
+          case Intrinsic::experimental_noalias_scope_decl:
             Users.emplace_back(I);
----------------
I guess this makes sense with the full version (that accepts an alloca). I don't think this can happen currently.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93042/new/

https://reviews.llvm.org/D93042