[PATCH] D94175: [VPlan] Move reduction start value creation to widenPHIRecipe.

[Gil Rapaport via Phabricator via llvm-commits]

gilr accepted this revision.
gilr added a comment.
This revision is now accepted and ready to land.

LGTM, with a nit.
(Seems reduction might be worth splitting widenPhiInstruction() and its own Recipe, but that's beyond the scope of this patch)
Thanks!



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4587
+
+    if (RdxDesc) {
+      RecurKind RK = RdxDesc->getRecurrenceKind();
----------------
To be on the safe side I'd check here for `Legal->isReductionVariable(P)` and assert that RdxDesc and StartV are not null inside.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94175/new/

https://reviews.llvm.org/D94175