[PATCH] D94311: [SlotIndexes] Fix and simplify basic block splitting

[Jay Foad via Phabricator via llvm-commits]

foad created this revision.
foad added reviewers: critson, qcolombet, kariddi, arsenm, MaskRay.
Herald added subscribers: arphaman, hiraditya, MatzeB.
foad requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Remove the InsertionPoint argument from SlotIndexes::insertMBBInMaps
because it was confusing: what does it mean to insert a new block
between two instructions, in the middle of an existing block?

Instead, support the case that MachineBasicBlock::splitAt really needs,
where the new block contains some instructions that are already in the
maps because they have been moved there from the tail of the previous
block.

In all other use cases the new block is empty.

Based on work by Carl Ritson!


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94311

Files:
  llvm/include/llvm/CodeGen/LiveIntervals.h
  llvm/include/llvm/CodeGen/SlotIndexes.h
  llvm/lib/CodeGen/MachineBasicBlock.cpp
  llvm/unittests/MI/LiveIntervalTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94311.315404.patch
Type: text/x-patch
Size: 5573 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210108/6c59857c/attachment.bin>