[PATCH] D91250: Support intrinsic overloading on unnamed types

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/docs/LangRef.rst:20074
 
-'``llvm.ssa_copy``' Intrinsic
+'``llvm.ssa.copy``' Intrinsic
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
----------------
submit the `llvm.ssa.copy` fixes separately?


================
Comment at: llvm/include/llvm/IR/Module.h:202
+      CurrentIntrinsicIds; ///< Keep track of the current unique id count for
+                           ///< the specified intrinsic basename
+  DenseMap<std::pair<Intrinsic::ID, const FunctionType *>, unsigned>
----------------
nit: period at end.


================
Comment at: llvm/include/llvm/IR/Module.h:204
+  DenseMap<std::pair<Intrinsic::ID, const FunctionType *>, unsigned>
+      UniquedIntrinsicNames; ///< Keep track of uniqued names of intrinsics
+                             ///< based on unnamed types
----------------
Where those the name come in here? It maps intrinsic ids to other ids?


================
Comment at: llvm/lib/IR/Function.cpp:809
+std::string Intrinsic::getName(ID id, ArrayRef<Type *> Tys) {
+  return getName(id, Tys, nullptr, nullptr);
+}
----------------
can we assert that there are no unnamed types involved here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91250/new/

https://reviews.llvm.org/D91250