[PATCH] D92747: [DAGCombiner] Use getVectorElementCount inside visitINSERT_SUBVECTOR
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 8 06:20:25 PST 2021
sdesmalen added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/dag-combine-insert-subvector.ll:9
+; If this check fails please read test/CodeGen/AArch64/README for instructions on how to resolve it.
+; CHECK-NOT: warning: {{.*}}Possible incorrect use of EVT::getVectorNumElements() for scalable vector
+
----------------
It's more robust not to test for specific warnings, but just check no warnings are emitted at all. When the time comes that the warning becomes an error, all tests are still guaranteed to pass.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92747/new/
https://reviews.llvm.org/D92747
More information about the llvm-commits
mailing list