[PATCH] D93755: [VE][isel] Map EVT vectors to vector registers.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D93755#2486281 <https://reviews.llvm.org/D93755#2486281>, @simoll wrote:

> This is one of those patches that has the potential to linger on without review for 1Y+ .. let me know if there is anything i can do to get this reviewed, as it really helps with bringing good vector architecture (long SIMD) support to LLVM. Thanks.

Can I interest you in moving to GlobalISel instead of trying to teach the DAG about new types :)



================
Comment at: llvm/lib/CodeGen/TargetLoweringBase.cpp:942
+  Optional<LegalizeKind> CustomLK = getCustomTypeConversion(Context, VT);
+  if (CustomLK.hasValue())
+    return CustomLK.getValue();
----------------
don't need hasValue()


================
Comment at: llvm/lib/CodeGen/TargetLoweringBase.cpp:943
+  if (CustomLK.hasValue())
+    return CustomLK.getValue();
+
----------------
*CustomLK


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93755/new/

https://reviews.llvm.org/D93755