[PATCH] D93766: [VP] ISD helper functions [VE] isel for vp_add, vp_and
Kazushi Marukawa via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 8 04:46:13 PST 2021
kaz7 accepted this revision.
kaz7 added a comment.
This revision is now accepted and ready to land.
LGTM also.
Two things to be improved in future:
1. I still think it's better to have `#define` and `#undef` at caller side to avoid that reviewer look at the end of header files every time.
2. It's better to use Opc or OPC instead of OC since it confuse me little bit each time. e.g. OC, OCOpt, and VVPOC variables are confusing me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93766/new/
https://reviews.llvm.org/D93766
More information about the llvm-commits
mailing list