[PATCH] D91516: [AMDGPU] Support for device scope shared variables

[Mahesha S via Phabricator via llvm-commits]

hsmhsm added a comment.

@arsenm

There are too many review comments - some are trivial and some are non-trivial. And I have my own doubts about some of the comments being made. Hence let's handle all these comments file by file and within a file, function by function. Otherwise, it only makes the review process more difficult.

Please go through my first set of inline comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91516/new/

https://reviews.llvm.org/D91516