[PATCH] D93743: [NewPM] Run ObjC ARC passes

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 18:01:37 PST 2021


aeubanks added a comment.

In D93743#2485876 <https://reviews.llvm.org/D93743#2485876>, @ahatanak wrote:

> Is this change safe considering calls to `EP.get()` can add function declarations to the module as you mentioned in https://reviews.llvm.org/D86178?

It's definitely safe right now since we have no support for concurrency right now. Many existing function passes will create function definitions, e.g. replacing some snippet with an intrinsic.
Of course if we ever decide to figure out concurrency we'll have to solve this issue, but we would have to solve it anyway even without this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93743/new/

https://reviews.llvm.org/D93743



More information about the llvm-commits mailing list