[PATCH] D93929: [NewPM][Hexagon] Fix HexagonVectorLoopCarriedReusePass position in pipeline

Ankit via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 16:17:02 PST 2021


quic_aankit added a subscriber: pranavb.
quic_aankit added a comment.

@asbirlea I remember that HexagonVLCR pass has a dependency on LCSSA and LoopSimplifyPass. Is there any way we can run these passes too at LoopOptimizerEndEP? If not maybe use another EP for legacy PM? I'm not sure if the below code would run these passes in the correct order as well

  PB.registerOptimizerLastEPCallback(
      [=](ModulePassManager &MPM, PassBuilder::OptimizationLevel Level) {
        LoopPassManager LPM(DebugPassManager);
        FunctionPassManager FPM(DebugPassManager);
        LPM.addPass(HexagonVectorLoopCarriedReusePass());
        FPM.addPass(LoopSimplifyPass());
        FPM.addPass(LCSSAPass());
        FPM.addPass(createFunctionToLoopPassAdaptor(std::move(LPM)));
        MPM.addPass(createModuleToFunctionPassAdaptor(std::move(FPM)));
      });

@pranavb Can you comment more on this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93929/new/

https://reviews.llvm.org/D93929



More information about the llvm-commits mailing list