[llvm] 8b9a0e6 - [NFC][SimlifyCFG] Add some indirectbr-of-blockaddress tests
Roman Lebedev via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 7 15:16:07 PST 2021
Author: Roman Lebedev
Date: 2021-01-08T02:15:25+03:00
New Revision: 8b9a0e6f7ed2fa3293ba5cd2c2fb1acd21db6e2d
URL: https://github.com/llvm/llvm-project/commit/8b9a0e6f7ed2fa3293ba5cd2c2fb1acd21db6e2d
DIFF: https://github.com/llvm/llvm-project/commit/8b9a0e6f7ed2fa3293ba5cd2c2fb1acd21db6e2d.diff
LOG: [NFC][SimlifyCFG] Add some indirectbr-of-blockaddress tests
Added:
Modified:
llvm/test/Transforms/SimplifyCFG/indirectbr.ll
Removed:
################################################################################
diff --git a/llvm/test/Transforms/SimplifyCFG/indirectbr.ll b/llvm/test/Transforms/SimplifyCFG/indirectbr.ll
index 52ef6b77166c..3c82f5a64ee3 100644
--- a/llvm/test/Transforms/SimplifyCFG/indirectbr.ll
+++ b/llvm/test/Transforms/SimplifyCFG/indirectbr.ll
@@ -1,17 +1,33 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -S -simplifycfg -simplifycfg-require-and-preserve-domtree=1 < %s | FileCheck %s
; SimplifyCFG should eliminate redundant indirectbr edges.
-; CHECK: indbrtest0
-; CHECK: indirectbr i8* %t, [label %BB0, label %BB1, label %BB2]
-; CHECK: %x = phi i32 [ 0, %BB0 ], [ 1, %entry ]
-
declare void @foo()
declare void @A()
declare void @B(i32)
declare void @C()
define void @indbrtest0(i8** %P, i8** %Q) {
+; CHECK-LABEL: @indbrtest0(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: store i8* blockaddress(@indbrtest0, [[BB0:%.*]]), i8** [[P:%.*]], align 8
+; CHECK-NEXT: store i8* blockaddress(@indbrtest0, [[BB1:%.*]]), i8** [[P]], align 8
+; CHECK-NEXT: store i8* blockaddress(@indbrtest0, [[BB2:%.*]]), i8** [[P]], align 8
+; CHECK-NEXT: call void @foo()
+; CHECK-NEXT: [[T:%.*]] = load i8*, i8** [[Q:%.*]], align 8
+; CHECK-NEXT: indirectbr i8* [[T]], [label [[BB0]], label [[BB1]], label %BB2]
+; CHECK: BB0:
+; CHECK-NEXT: call void @A()
+; CHECK-NEXT: br label [[BB1]]
+; CHECK: BB1:
+; CHECK-NEXT: [[X:%.*]] = phi i32 [ 0, [[BB0]] ], [ 1, [[ENTRY:%.*]] ]
+; CHECK-NEXT: call void @B(i32 [[X]])
+; CHECK-NEXT: ret void
+; CHECK: BB2:
+; CHECK-NEXT: call void @C()
+; CHECK-NEXT: ret void
+;
entry:
store i8* blockaddress(@indbrtest0, %BB0), i8** %P
store i8* blockaddress(@indbrtest0, %BB1), i8** %P
@@ -35,10 +51,17 @@ BB2:
; better if it removed the branch altogether, but simplifycfdg currently misses
; that because the predecessor is the entry block.
-; CHECK: indbrtest1
-; CHECK: br label %BB0
define void @indbrtest1(i8** %P, i8** %Q) {
+; CHECK-LABEL: @indbrtest1(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: store i8* blockaddress(@indbrtest1, [[BB0:%.*]]), i8** [[P:%.*]], align 8
+; CHECK-NEXT: call void @foo()
+; CHECK-NEXT: br label [[BB0]]
+; CHECK: BB0:
+; CHECK-NEXT: call void @A()
+; CHECK-NEXT: ret void
+;
entry:
store i8* blockaddress(@indbrtest1, %BB0), i8** %P
call void @foo()
@@ -52,11 +75,12 @@ BB0:
; SimplifyCFG should notice that BB0 does not have its address taken and
; remove it from entry's successor list.
-; CHECK: indbrtest2
-; CHECK: entry:
-; CHECK-NEXT: unreachable
define void @indbrtest2(i8* %t) {
+; CHECK-LABEL: @indbrtest2(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: unreachable
+;
entry:
indirectbr i8* %t, [label %BB0, label %BB0]
BB0:
@@ -77,13 +101,17 @@ BB0:
; SimplifyCFG should turn the indirectbr into a conditional branch on the
; condition of the select.
-; CHECK-LABEL: @indbrtest3(
-; CHECK-NEXT: entry:
-; CHECK-NEXT: br i1 %cond, label %L1, label %L2
-; CHECK-NOT: indirectbr
-; CHECK-NOT: br
-; CHECK-NOT: L3:
define void @indbrtest3(i1 %cond, i8* %address) nounwind {
+; CHECK-LABEL: @indbrtest3(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: br i1 [[COND:%.*]], label [[L1:%.*]], label [[L2:%.*]]
+; CHECK: L1:
+; CHECK-NEXT: call void @A()
+; CHECK-NEXT: ret void
+; CHECK: L2:
+; CHECK-NEXT: call void @C()
+; CHECK-NEXT: ret void
+;
entry:
%indirect.goto.dest = select i1 %cond, i8* blockaddress(@indbrtest3, %L1), i8* blockaddress(@indbrtest3, %L2)
indirectbr i8* %indirect.goto.dest, [label %L1, label %L2, label %L3]
@@ -104,10 +132,14 @@ L3:
; As in @indbrtest1, it should really remove the branch entirely, but it doesn't
; because it's in the entry block.
-; CHECK-LABEL: @indbrtest4(
-; CHECK-NEXT: entry:
-; CHECK-NEXT: br label %L1
define void @indbrtest4(i1 %cond) nounwind {
+; CHECK-LABEL: @indbrtest4(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: br label [[L1:%.*]]
+; CHECK: L1:
+; CHECK-NEXT: call void @A()
+; CHECK-NEXT: ret void
+;
entry:
%indirect.goto.dest = select i1 %cond, i8* blockaddress(@indbrtest4, %L1), i8* blockaddress(@indbrtest4, %L1)
indirectbr i8* %indirect.goto.dest, [label %L1, label %L2, label %L3]
@@ -126,11 +158,11 @@ L3:
; SimplifyCFG should turn the indirectbr into an unreachable because neither
; destination is listed as a successor.
-; CHECK-LABEL: @indbrtest5(
-; CHECK-NEXT: entry:
-; CHECK-NEXT: unreachable
-; CHECK-NEXT: }
define void @indbrtest5(i1 %cond, i8* %anchor) nounwind {
+; CHECK-LABEL: @indbrtest5(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: unreachable
+;
entry:
%indirect.goto.dest = select i1 %cond, i8* blockaddress(@indbrtest5, %L1), i8* blockaddress(@indbrtest5, %L2)
; This needs to have more than one successor for this test, otherwise it gets
@@ -156,11 +188,11 @@ L4:
; The same as above, except the selected addresses are equal.
-; CHECK-LABEL: @indbrtest6(
-; CHECK-NEXT: entry:
-; CHECK-NEXT: unreachable
-; CHECK-NEXT: }
define void @indbrtest6(i1 %cond, i8* %anchor) nounwind {
+; CHECK-LABEL: @indbrtest6(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: unreachable
+;
entry:
%indirect.goto.dest = select i1 %cond, i8* blockaddress(@indbrtest6, %L1), i8* blockaddress(@indbrtest6, %L1)
; This needs to have more than one successor for this test, otherwise it gets
@@ -186,6 +218,28 @@ L3:
@xblkx.bbs = internal unnamed_addr constant [9 x i8*] [i8* blockaddress(@indbrtest7, %xblkx.begin), i8* blockaddress(@indbrtest7, %xblkx.begin3), i8* blockaddress(@indbrtest7, %xblkx.begin4), i8* blockaddress(@indbrtest7, %xblkx.begin5), i8* blockaddress(@indbrtest7, %xblkx.begin6), i8* blockaddress(@indbrtest7, %xblkx.begin7), i8* blockaddress(@indbrtest7, %xblkx.begin8), i8* blockaddress(@indbrtest7, %xblkx.begin9), i8* blockaddress(@indbrtest7, %xblkx.end)]
define void @indbrtest7() {
+; CHECK-LABEL: @indbrtest7(
+; CHECK-NEXT: escape-string.top:
+; CHECK-NEXT: [[XVAL202X:%.*]] = call i32 @xfunc5x()
+; CHECK-NEXT: br label [[XLAB5X:%.*]]
+; CHECK: xlab8x:
+; CHECK-NEXT: [[XVALUEX:%.*]] = call i32 @xselectorx()
+; CHECK-NEXT: [[XBLKX_X:%.*]] = getelementptr [9 x i8*], [9 x i8*]* @xblkx.bbs, i32 0, i32 [[XVALUEX]]
+; CHECK-NEXT: [[XBLKX_LOAD:%.*]] = load i8*, i8** [[XBLKX_X]], align 8
+; CHECK-NEXT: indirectbr i8* [[XBLKX_LOAD]], [label [[XLAB4X:%.*]], label %v2j]
+; CHECK: v2j:
+; CHECK-NEXT: [[XUNUSEDX:%.*]] = call i32 @xactionx()
+; CHECK-NEXT: br label [[XLAB4X]]
+; CHECK: xlab4x:
+; CHECK-NEXT: [[INCR19:%.*]] = add i32 [[XVAL704X_0:%.*]], 1
+; CHECK-NEXT: br label [[XLAB5X]]
+; CHECK: xlab5x:
+; CHECK-NEXT: [[XVAL704X_0]] = phi i32 [ 0, [[ESCAPE_STRING_TOP:%.*]] ], [ [[INCR19]], [[XLAB4X]] ]
+; CHECK-NEXT: [[XVAL10X:%.*]] = icmp ult i32 [[XVAL704X_0]], [[XVAL202X]]
+; CHECK-NEXT: br i1 [[XVAL10X]], label [[XLAB8X:%.*]], label [[XLAB9X:%.*]]
+; CHECK: xlab9x:
+; CHECK-NEXT: ret void
+;
escape-string.top:
%xval202x = call i32 @xfunc5x()
br label %xlab5x
@@ -225,7 +279,6 @@ xblkx.end:
br i1 %yes.0, label %v2j, label %xlab17x
v2j:
-; CHECK: %xunusedx = call i32 @xactionx()
%xunusedx = call i32 @xactionx()
br label %xlab4x
@@ -245,6 +298,85 @@ xlab9x:
ret void
}
+define void @indbrtest8() {
+; CHECK-LABEL: @indbrtest8(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: call void @B(i32 undef)
+; CHECK-NEXT: ret void
+;
+entry:
+ indirectbr i8* blockaddress(@indbrtest8, %BB1), [label %BB0, label %BB1]
+BB0:
+ call void @A()
+ ret void
+BB1:
+ call void @B(i32 undef)
+ ret void
+}
+
+define void @indbrtest9() {
+; CHECK-LABEL: @indbrtest9(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: unreachable
+;
+entry:
+ indirectbr i8* blockaddress(@indbrtest9, %BB1), [label %BB0]
+BB0:
+ call void @A()
+ ret void
+BB1:
+ call void @B(i32 undef)
+ ret void
+}
+
+define void @indbrtest10() {
+; CHECK-LABEL: @indbrtest10(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: call void @B(i32 undef)
+; CHECK-NEXT: ret void
+;
+entry:
+ indirectbr i8* blockaddress(@indbrtest10, %BB1), [label %BB1]
+BB0:
+ call void @A()
+ ret void
+BB1:
+ call void @B(i32 undef)
+ ret void
+}
+
+define void @indbrtest11() {
+; CHECK-LABEL: @indbrtest11(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: call void @A()
+; CHECK-NEXT: ret void
+;
+entry:
+ indirectbr i8* blockaddress(@indbrtest11, %BB0), [label %BB0, label %BB1, label %BB1]
+BB0:
+ call void @A()
+ ret void
+BB1:
+ call void @B(i32 undef)
+ ret void
+}
+
+define void @indbrtest12() {
+; CHECK-LABEL: @indbrtest12(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: call void @B(i32 undef)
+; CHECK-NEXT: ret void
+;
+entry:
+ indirectbr i8* blockaddress(@indbrtest12, %BB1), [label %BB0, label %BB1, label %BB1]
+BB0:
+ call void @A()
+ ret void
+BB1:
+ call void @B(i32 undef)
+ ret void
+}
+
declare i32 @xfunc5x()
declare i8 @xfunc7x()
declare i32 @xselectorx()
More information about the llvm-commits
mailing list