[llvm] b2dafd4 - [NewPM][Hexagon] Fix HexagonVectorLoopCarriedReusePass position in pipeline

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 15:04:39 PST 2021


Author: Arthur Eubanks
Date: 2021-01-07T15:04:28-08:00
New Revision: b2dafd44ca7a975e3d58d68f3a24e36b2ceb2e1e

URL: https://github.com/llvm/llvm-project/commit/b2dafd44ca7a975e3d58d68f3a24e36b2ceb2e1e
DIFF: https://github.com/llvm/llvm-project/commit/b2dafd44ca7a975e3d58d68f3a24e36b2ceb2e1e.diff

LOG: [NewPM][Hexagon] Fix HexagonVectorLoopCarriedReusePass position in pipeline

In https://reviews.llvm.org/D88138 this was incorrectly added with
registerOptimizerLastEPCallback(), when it should be
registerLoopOptimizerEndEPCallback(), matching the legacy PM's
EP_LoopOptimizerEnd.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D93929

Added: 
    

Modified: 
    llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp b/llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp
index 23c047e0c23b..ba0f45fe09f7 100644
--- a/llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp
@@ -287,13 +287,9 @@ void HexagonTargetMachine::registerPassBuilderCallbacks(PassBuilder &PB,
       [=](LoopPassManager &LPM, PassBuilder::OptimizationLevel Level) {
         LPM.addPass(HexagonLoopIdiomRecognitionPass());
       });
-  PB.registerOptimizerLastEPCallback(
-      [=](ModulePassManager &MPM, PassBuilder::OptimizationLevel Level) {
-        LoopPassManager LPM(DebugPassManager);
-        FunctionPassManager FPM(DebugPassManager);
+  PB.registerLoopOptimizerEndEPCallback(
+      [=](LoopPassManager &LPM, PassBuilder::OptimizationLevel Level) {
         LPM.addPass(HexagonVectorLoopCarriedReusePass());
-        FPM.addPass(createFunctionToLoopPassAdaptor(std::move(LPM)));
-        MPM.addPass(createModuleToFunctionPassAdaptor(std::move(FPM)));
       });
 }
 


        


More information about the llvm-commits mailing list