[PATCH] D93433: [IR] Use LLVM_ENABLE_ABI_BREAKING_CHECKS to guard ABI changes.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 7 14:19:30 PST 2021
dblaikie added inline comments.
================
Comment at: llvm/include/llvm/IR/ValueHandle.h:489
ValueTy *getValPtr() const {
assert(!Poisoned && "Accessed a poisoned value handle!");
return static_cast<ValueTy *>(getRawValPtr());
----------------
Missed this usage (probably worth building with/without ABI breaking checks in the future to validate these sort of changes) which breaks the non-abi-breaking-checks build. Oh, and some death unit tests no longer worked/needed to be protected by ABI_BREAKING_CHECKS as well as !NDEBUG.
Fixed in: 3503c856819efc01ce210fa56e597ddfb7a4c1a1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93433/new/
https://reviews.llvm.org/D93433
More information about the llvm-commits
mailing list