D92434: AMDGPU code object V4 ABI -- docs don't quite match the source tree state.

[Artem Belevich via llvm-commits]

Hi,

It appears that the AMDGPU documentation updated in
https://reviews.llvm.org/D92434 does not quite match the code we currently
have in the LLVM source tree.

It's not very helpful when the recently-updated public docs say one thing,
but the code does something completely different.

E.g. I'm failing to find ELF::EF_AMDGPU_FEATURE_XNACK_V2 and other new
flags it describes. At the same time, the flags that were removed from the
documentation are still there (e.g EF_AMDGPU_XNACK)
https://github.com/llvm/llvm-project/blob/4e2e785ddd35c421a4df9453f17b8317d6b62b2c/llvm/include/llvm/BinaryFormat/ELF.h#L738

AFAICT, the current state of the tree matches V3 ABI, but uses different
constant names than the ones used in the docs.

Are the corresponding code changes handled in a separate review? If so, I'd
appreciate it if you could point me in the right direction and, maybe,
update the review tracker, too.

If the code is not quite ready yet, perhaps it would make sense to postpone
doc updates (at least the parts that remove the info about the *current*
state of the source tree) until the code is ready and clearly mark the
parts of the documentation that describe things that do not exist yet.


Thank you,
--Artem Belevich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210107/7eb20cd9/attachment.html>