[PATCH] D94254: Fix gcc5 build failure (NFC)
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 7 12:12:28 PST 2021
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG467e916d3032: Fix gcc5 build failure (NFC) (authored by mehdi_amini).
Changed prior to commit:
https://reviews.llvm.org/D94254?vs=315196&id=315199#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94254/new/
https://reviews.llvm.org/D94254
Files:
llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp
Index: llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp
+++ llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp
@@ -330,11 +330,11 @@
// FIXME: This is mostly nasty pre-processing before handleAssignments. Most
// of this should be performed by handleAssignments.
- int SplitIdx = 0;
- for (const ArgInfo &SplitArg : SplitArg) {
+ for (int SplitIdx = 0, e = SplitArg.size(); SplitIdx != e; ++SplitIdx) {
+ const ArgInfo &CurSplitArg = SplitArg[SplitIdx];
Register Reg = OrigArg.Regs[SplitIdx];
- EVT VT = EVT::getEVT(SplitArg.Ty);
- LLT LLTy = getLLTForType(*SplitArg.Ty, DL);
+ EVT VT = EVT::getEVT(CurSplitArg.Ty);
+ LLT LLTy = getLLTForType(*CurSplitArg.Ty, DL);
unsigned NumParts = TLI.getNumRegistersForCallingConv(Ctx, CallConv, VT);
MVT RegVT = TLI.getRegisterTypeForCallingConv(Ctx, CallConv, VT);
@@ -342,9 +342,8 @@
if (NumParts == 1) {
// No splitting to do, but we want to replace the original type (e.g. [1 x
// double] -> double).
- SplitArgs.emplace_back(Reg, SplitArg.Ty, OrigArg.Flags, OrigArg.IsFixed);
-
- ++SplitIdx;
+ SplitArgs.emplace_back(Reg, CurSplitArg.Ty, OrigArg.Flags,
+ OrigArg.IsFixed);
continue;
}
@@ -362,8 +361,6 @@
}
PerformArgSplit(SplitRegs, Reg, LLTy, PartLLT, SplitIdx);
-
- ++SplitIdx;
}
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94254.315199.patch
Type: text/x-patch
Size: 1479 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210107/d75bac48/attachment.bin>
More information about the llvm-commits
mailing list