[PATCH] D93876: Do not implicitly turn on function sections with basic block sections.

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added a comment.

In D93876#2484989 <https://reviews.llvm.org/D93876#2484989>, @dblaikie wrote:

> In D93876#2483702 <https://reviews.llvm.org/D93876#2483702>, @tmsriram wrote:
>
>> In D93876#2474377 <https://reviews.llvm.org/D93876#2474377>, @dblaikie wrote:
>>
>>>> This patch disables this implicit behavior. It only creates function sections for those functions that require basic block sections.
>>>
>>> Is this necessary? I would guess even with a bb sections function, its main section could go in the generic .text section?
>>
>> But we want the .text section to be unique because we want reorder functions at link time. Does that make sense?
>
> Somewhat - but if the user wants reordering, wouldn't they want -ffunction-sections too?
>
> I guess if they use bb-sections but not function-sections that assumes selective bb-sections would apply to all the hot functions? So that lets the hot code be reordered, and all the functions that aren't bb-split would go in one big .text section and be considered "not hot"?

Yep, +1 on the last point. That is what I was trying to say but clearly failed to communicate as well :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93876/new/

https://reviews.llvm.org/D93876