[PATCH] D94140: [WebAssembly] Fixed byval args missing DWARF DW_AT_LOCATION

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/dbgvalue.ll:4
 ; CHECK: %bb.0
-; CHECK: #DEBUG_VALUE: usage:self <- %4
+; CHECK: #DEBUG_VALUE: usage:self <- !target-index(0,0)
 ; CHECK: %bb.1
----------------
aprantl wrote:
> it would be nicer if we piped the output to llvm-dwarfdump and CHECK that output rather than checking for a comment in the assembler output.
Agreed dwarfdump is the more exact way to do this. Here I am fixing an existing test though, and we have plenty of dwarfdump based tests already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94140/new/

https://reviews.llvm.org/D94140