[PATCH] D94209: Introduce `UnIgnoreObjectLocked` functions
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 7 10:29:56 PST 2021
delcypher added inline comments.
================
Comment at: compiler-rt/lib/lsan/lsan_common.h:245
// Helper for __lsan_ignore_object().
IgnoreObjectResult IgnoreObjectLocked(const void *p);
+IgnoreObjectResult UnIgnoreObjectLocked(const void *p);
----------------
vitalybuka wrote:
> maybe we need __lsan_unignore_object for consistency and a test
Thanks. I considered this but IIRC we have a very conservative policy of changing the public interface of the sanitizers so I decided to not add a public interface.
I'm not against adding a public interface + a test though but because the end goal is https://reviews.llvm.org/D94210 and it looks like we may have to implement it differently I'll leave this patch as is for now until we know if using `UnIgnoreObjectLocked()` is the right approach.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94209/new/
https://reviews.llvm.org/D94209
More information about the llvm-commits
mailing list