[PATCH] D93731: [wip] scudo: Support memory tagging in the secondary allocator.

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/secondary.h:60
+static void unmap(LargeBlock::Header *H) {
+  unmap(reinterpret_cast<void *>(H->MapBase), H->MapSize, UNMAP_ALL, &H->Data);
+}
----------------
The Fuchsia error is here: Fuchsia `unmap` tries to write to `&H->Data` post unmapping, so it results in an access violation.
The solution is to use a local `Data` variable that would store the header's `Data`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93731/new/

https://reviews.llvm.org/D93731