[PATCH] D94238: [NFC] Minor cleanup for ValueHandle code.

Varun Gandhi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 08:51:14 PST 2021


varungandhi-apple created this revision.
varungandhi-apple added a reviewer: dblaikie.
Herald added a subscriber: dexonsmith.
varungandhi-apple requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Based on feedback in https://reviews.llvm.org/D93433.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94238

Files:
  llvm/include/llvm/IR/ValueHandle.h


Index: llvm/include/llvm/IR/ValueHandle.h
===================================================================
--- llvm/include/llvm/IR/ValueHandle.h
+++ llvm/include/llvm/IR/ValueHandle.h
@@ -287,7 +287,7 @@
 #else
   AssertingVH() : ThePtr(nullptr) {}
   AssertingVH(ValueTy *P) : ThePtr(GetAsValue(P)) {}
-  AssertingVH(const AssertingVH<ValueTy> &) = default;
+  AssertingVH(const AssertingVH &) = default;
 #endif
 
   operator ValueTy*() const {
@@ -442,9 +442,9 @@
 /// PoisoningVH's as it moves. This is required because in non-assert mode this
 /// class turns into a trivial wrapper around a pointer.
 template <typename ValueTy>
-class PoisoningVH
+class PoisoningVH final
 #if LLVM_ENABLE_ABI_BREAKING_CHECKS
-    final : public CallbackVH
+    : public CallbackVH
 #endif
 {
   friend struct DenseMapInfo<PoisoningVH<ValueTy>>;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94238.315155.patch
Type: text/x-patch
Size: 840 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210107/8e0de9b4/attachment.bin>


More information about the llvm-commits mailing list