[PATCH] D93891: [DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

In D93891#2481354 <https://reviews.llvm.org/D93891#2481354>, @steven.zhang wrote:

> Hmm, so we can try to remove those parts that not relative with the parameter arsenm mentioned. I guess most of the check in the DAGCombiner could be removed if I understand correctly. To remove it completely, some work is needed for parameters or others that current IR cannot represent the semantics of the global setting. Is it right ?
>
> Maybe, we can start it with this simple patch first ?

That sounds right to me, so LGTM. 
We will need to allow FMF on any FP value (including loads and arguments) to finally get rid of the global options. We added FMF on phi/select in IR over a year ago, but it doesn't go far enough to handle cases like:
https://bugs.llvm.org/show_bug.cgi?id=35607#c9
(also see the related bugs for more background).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93891/new/

https://reviews.llvm.org/D93891