[PATCH] D92953: [GlobalISel] Base implementation for sret demotion.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 10:07:22 PST 2021


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h:318-320
+  void handleSRetLoads(MachineIRBuilder &MIRBuilder, Type *RetTy,
+                       ArrayRef<Register> VRegs, Register DemoteReg,
+                       int FI) const;
----------------
s/handle/insert/?

Should this return DemoteReg rather than accept it as an argument?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92953/new/

https://reviews.llvm.org/D92953



More information about the llvm-commits mailing list