[PATCH] D93039: Introduce llvm.noalias.decl intrinsic

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere marked 5 inline comments as done.
jeroen.dobbelaere added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:556
+                [llvm_anyptr_ty, llvm_anyint_ty, llvm_metadata_ty],
+                [IntrArgMemOnly]>; // ArgMemOnly: blocks LICM and some more
+
----------------
jdoerfert wrote:
> jeroen.dobbelaere wrote:
> > nikic wrote:
> > > The ArgMemOnly here seems a bit dubious. This means it can read/write the p.alloca argument, which I assume is not intended (even if it's unused now).
> > > 
> > > I guess we can't make this `NoMem`, because then it could simply be DCEd right? Maybe it should be InaccessibleMemOnly?
> > That might also work.
> I don't think it should be DCEd if used. `NoMem` seems logical to me.
NoMem would allow to optimize it away. IntrInaccessibleMemOnly seems the closest fit today.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93039/new/

https://reviews.llvm.org/D93039