[PATCH] D94230: [AArch64][SVE] Add SVE IR pass to coalesce ptrue instrinsic calls

[Joe Ellis via Phabricator via llvm-commits]

joechrisellis added a comment.

In D94230#2484200 <https://reviews.llvm.org/D94230#2484200>, @fhahn wrote:

> It seems there is already a pass to optimize SVE intrinsics. Is there a reason to add a another separate pass, rather than extending the existing one?

Hi @fhahn -- the reason I created a new pass here is because `SVEIntrinsicOpts.cpp` works on an instruction basis -- i.e. look at each SVE intrinsic call in isolation and see what can be done locally from there. On the other hand, the optimisation implemented by this pass instead requires you to look at the set of ptrue intrinsic calls in each basic block, which is not so easy to do within the existing structure of the `sve-intrinsic-opts` pass. I think it's probably cleaner to add a new pass to handle this, but I am open to suggestions. 😄


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94230/new/

https://reviews.llvm.org/D94230