[PATCH] D92385: [ARM] Add a pass that re-arranges blocks when there is a backwards WLS branch

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 06:10:00 PST 2021


samtebbs added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBlockPlacement.cpp:75
+  for (auto ML : *MLI) {
+    MachineBasicBlock *BB = ML->getLoopPredecessor();
+
----------------
SjoerdMeijer wrote:
> I forgot what the exact difference is between `getLoopPredecessor` and `getLoopPreheader`, but I guess calling `BB` `Preheader` will help a bit here.
Good idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92385/new/

https://reviews.llvm.org/D92385



More information about the llvm-commits mailing list