[PATCH] D89490: Introduce __attribute__((darwin_abi))

[Adrien Guinet via Phabricator via llvm-commits]

aguinet added a comment.

In D89490#2482531 <https://reviews.llvm.org/D89490#2482531>, @rjmccall wrote:

> I'm not calling Wine a niche use-case, I'm calling this feature a niche use-case.  The lack of this feature has not blocked Wine from being a successful project.  The feature has to stand on its own and be more broadly useful than the momentary convenience of a few developers.

I am not saying this **exact** feature is needed by Wine. What I am doing is a parallel with `__attribute__((ms_abi))`, which is exactly the same as this exact feature, but to target the MS ABI from a foreign OS (instead of the Darwin one). Wine just can't work without that attribute.

Let's imagine that, at the time people had wanted to introduce `__attribute__((ms_abi))`, we would have told them "this is a niche, hack <insert compiler representation> instead". Do you really think that would have been a serious solution?

I'd say that we are in a chicken and egg problem: we don't have users for this, but maybe because we don't have the feature. We already have internal tools that are using this feature, and have lots of hopes it will simplify some of our more complex internal CI and debugging processes. We plan to open source all of this, because we also believe that will also help others with the same kind of issues. But I agree that we might be wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89490/new/

https://reviews.llvm.org/D89490