[PATCH] D93346: [Test][FileCheck] Fix use of undef var

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 00:28:55 PST 2021


jhenderson added inline comments.


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:249
 RUN: %ProtectFileCheckOutput \
-RUN: not FileCheck --check-prefix NUMEXPR-CONSTRAINT-NOMATCH --input-file %s %s 2>&1 \
+RUN: not FileCheck --check-prefixes CHECK,NUMEXPR-CONSTRAINT-NOMATCH --input-file %s %s 2>&1 \
 RUN:   | FileCheck --check-prefix NUMEXPR-CONSTRAINT-NOMATCH-MSG --strict-whitespace %s
----------------
Rather than requiring the whole CHECK patterns to be checked as part of this, would it make more sense to just use -D to define `UNSI`, something like the suggested edit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93346/new/

https://reviews.llvm.org/D93346



More information about the llvm-commits mailing list