[PATCH] D93876: Do not implicitly turn on function sections with basic block sections.

Wed Jan 6 23:06:56 PST 2021

tmsriram added a comment.

In D93876#2474377 <https://reviews.llvm.org/D93876#2474377>, @dblaikie wrote:

>> This patch disables this implicit behavior. It only creates function sections for those functions that require basic block sections.
>
> Is this necessary? I would guess even with a bb sections function, its main section could go in the generic .text section?

But we want the .text section to be unique because we want reorder functions at link time. Does that make sense?

In D93876#2474241 <https://reviews.llvm.org/D93876#2474241>, @rahmanl wrote:

> Can we add a test with the `=list` option to verify that functions not requiring basic block sections are not emitted in unique sections?
> Or maybe we can use the existing `basic-block-sections-list.ll` by adding a new invocation without `-function-sections`.

Good suggestion, I extended the test.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93876/new/

https://reviews.llvm.org/D93876