[PATCH] D94213: Clang: Remove support for 3DNow!, both intrinsics and builtins.

[James Y Knight via Phabricator via llvm-commits]

jyknight created this revision.
jyknight added reviewers: craig.topper, spatel, RKSimon.
Herald added subscribers: dang, pengfei.
jyknight requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.

This set of instructions was only supported by AMD chips starting in
the K6 <https://reviews.llvm.org/K6>-2 (introduced 1998), and before the "Bulldozer" family
(2011). They were never much used, as they were effectively superseded
by the more-widely-implemented SSE (first implemented on the AMD side
in Athlon XP in 2001).

As part of the general removal of MMX register usage
(https://reviews.llvm.org/D86855), something also needs to be done
with the 3dnow intrinsics. Since there is almost no usage of these,
and no hardware implements them, simple removal of both the intrinsics
and the corresponding `__3dNOW__` feature define seems like the best
option.

Support for the underlying LLVM intrinsics remains unchanged, at least
for the moment, although it quite likely makes sense to remove support
on the LLVM side as well.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94213

Files:
  clang/include/clang/Basic/BuiltinsX86.def
  clang/include/clang/Driver/Options.td
  clang/lib/Basic/Targets/X86.cpp
  clang/lib/Basic/Targets/X86.h
  clang/lib/CodeGen/CGBuiltin.cpp
  clang/lib/Driver/ToolChains/Arch/X86.cpp
  clang/lib/Headers/mm3dnow.h
  clang/lib/Headers/x86intrin.h
  clang/test/CodeGen/X86/3dnow-builtins.c
  clang/test/CodeGen/builtins-x86.c
  clang/test/Driver/x86-target-features.c
  clang/test/Headers/mm3dnow.c
  clang/test/Preprocessor/predefined-arch-macros.c
  clang/test/Preprocessor/x86_target_features.c
  llvm/include/llvm/IR/IntrinsicsX86.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94213.315041.patch
Type: text/x-patch
Size: 48860 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210107/6a3708fb/attachment.bin>