[PATCH] D93503: [GVN] Propagate llvm.access.group metadata of loads

KAWASHIMA Takahiro via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 17:50:20 PST 2021


kawashima-fj added a comment.

In D93503#2479425 <https://reviews.llvm.org/D93503#2479425>, @fhahn wrote:

> This seems reasonable to me, as we should only reduce the number of loads executed during PRE. If they are in the same loop, the metadata should stay valid, as we do not access any additional locations.
>
> Would it be possible to add a simple test case where we move a load from a sub-loop into a parent loop?

Thanks for your review.
The test in the previous revision is refined. I might not understand your comment correctly. If I missed something, please let me know.
My colleague, who fixed this issue, is busy now. The requested additional test can be added next week or so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93503/new/

https://reviews.llvm.org/D93503



More information about the llvm-commits mailing list