[PATCH] D94207: [NFC] Refactor `IgnoreObjectLocked`
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 6 17:47:57 PST 2021
delcypher added inline comments.
================
Comment at: compiler-rt/lib/asan/asan_allocator.cpp:1172
-IgnoreObjectResult IgnoreObjectLocked(const void *p) {
+static ALWAYS_INLINE __asan::AsanChunk *LookUpValidChunk(const void *p) {
uptr addr = reinterpret_cast<uptr>(p);
----------------
vitalybuka wrote:
> do we need ALWAYS_INLINE?
Technically, no. I put it there because I thought it should probably be inlined (I wasn't sure if `static` would be a strong enough hint) but this is probably premature optimization on my part.
Please let me know if you'd like me to remove it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94207/new/
https://reviews.llvm.org/D94207
More information about the llvm-commits
mailing list