[PATCH] D94154: Unique Internal Linkage Name suffixes must be demangler friendly

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 16:40:02 PST 2021


hoy added a comment.

In D94154#2483336 <https://reviews.llvm.org/D94154#2483336>, @tmsriram wrote:

> https://github.com/gcc-mirror/gcc/blob/master/libiberty/cp-demangle.c#L3863
>
> The demangler code for suffixes that accepts either lowercase letters with underscore or numbers.

Thanks for pointing out. And we already do something like that during LTO symbol promotion: https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/IR/ModuleSummaryIndex.h#L1376


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94154/new/

https://reviews.llvm.org/D94154



More information about the llvm-commits mailing list