[PATCH] D93731: [wip] scudo: Support memory tagging in the secondary allocator.

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 16:35:19 PST 2021


cryptoad added a comment.

In D93731#2482877 <https://reviews.llvm.org/D93731#2482877>, @pcc wrote:

> It's ready to go in if you don't mind me breaking Fuchsia. Otherwise I can wait for a Fuchsia implementation of setMemoryPermission() from you.

Trying the following:

  void setMemoryPermission(uptr Addr, uptr Size, uptr Flags,
                           MapPlatformData *Data) {
    const zx_vm_option_t Prot =
        (Flags & MAP_NOACCESS) ? 0 : (ZX_VM_PERM_READ | ZX_VM_PERM_WRITE);
    DCHECK(Data);
    DCHECK_NE(Data->Vmar, ZX_HANDLE_INVALID);
    if (_zx_vmar_protect(Data->Vmar, Prot, Addr, Size) != ZX_OK)
      dieOnMapUnmapError();
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93731/new/

https://reviews.llvm.org/D93731



More information about the llvm-commits mailing list