[PATCH] D88232: [DebugInfo] Handle multiple variable location operands in IR

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1225
     Instruction &VAsInst = *cast<Instruction>(V);
-    DIExpression *NewExpr = salvageDebugInfoImpl(VAsInst, Expr, StackValue);
+    // Temporary "0", awaiting real implementation.
+    DIExpression *NewExpr = salvageDebugInfoImpl(VAsInst, Expr, StackValue, 0);
----------------
djtodoro wrote:
> So here we will be using the new metadata by salvaging dbg.values with multiple SSA values?
Yes, this isn't currently implemented in the patch stack, but should be implemented later. It's definitely out of scope for this patch, regardless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88232/new/

https://reviews.llvm.org/D88232