[PATCH] D94017: [flang] Fix bogus message on internal subprogram with alternate return

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added inline comments.


================
Comment at: flang/lib/Semantics/expression.cpp:2868
+                   actual = ActualArgument(x.v);
                    isAltReturn = true;
                  },
----------------
klausler wrote:
> This variable, and the code later that it enables, may no longer be needed; I'm not sure why it's there.
It does seem wrong to create data that's never used.

@schweitz, as I understand things, the current lowering code gets the value of alternate return labels from the parse tree.  Do you plan to change that once their available in the values of the ActualArgument?

Note that there are a couple of ways that this value is used.  One is for the implementation of the function isAlternateReturn().  The other is that you can now dump out the value of the label in the actual argument if you dump it out.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94017/new/

https://reviews.llvm.org/D94017