[PATCH] D94189: [ARM] Update isVMOVNOriginalMask to handle single input shuffle vectors

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 12:58:51 PST 2021


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks like a good fix to me.



================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:14731
 
-    for (unsigned i = 0; i < NumElts; i += 2) {
-      if (M[i] >= 0 && M[i] != (int)(Off0 + i / 2))
+    for (unsigned I = 0; I < NumElts; I += 2) {
+      if (M[I] >= 0 && M[I] != (int)(Off0 + I / 2))
----------------
Nit: not that I care about this, but I guess or hope it would be fine to have lower case `i` because it's a loop iterator?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94189/new/

https://reviews.llvm.org/D94189



More information about the llvm-commits mailing list