[PATCH] D94153: [AMDGPU][Inliner] Remove amdgpu-inline and add new TTI inline hooks

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:1152
+
+bool GCNTTIImpl::mustNotInline(const CallBase *CB) const {
+  const Function *Caller = CB->getCaller();
----------------
arsenm wrote:
> aeubanks wrote:
> > arsenm wrote:
> > > I'm not sure I like having a target hook for a hack like this
> > Would you rather just remove this altogether?
> I don't remember the story here. @rampitec @vpykhtin @dfukalov ?
It was added in https://reviews.llvm.org/D62917.
Apparently it's a hack to help with compile times. That's a bit surprising, is this an AMDGPU specific issue?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94153/new/

https://reviews.llvm.org/D94153