[PATCH] D94146: AMDGPU/GlobalISel: Add baseline IR tests for fdiv

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 08:34:42 PST 2021


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/fdiv.f16.ll:54-74
+; GFX8-LABEL: v_fdiv_f16:
+; GFX8:       ; %bb.0:
+; GFX8-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; GFX8-NEXT:    v_cvt_f32_f16_e32 v2, v1
+; GFX8-NEXT:    v_cvt_f32_f16_e32 v3, v0
+; GFX8-NEXT:    v_rcp_f32_e32 v2, v2
+; GFX8-NEXT:    v_mul_f32_e32 v2, v3, v2
----------------
foad wrote:
> Would update_llc_test_checks common these up if you added a GFX89 prefix? Same for loads of other tests.
Apparently it is (I wasn't smart enough to order the checks from most preferred to least)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94146/new/

https://reviews.llvm.org/D94146



More information about the llvm-commits mailing list