[PATCH] D94065: [NFC] Make remaining cost functions in LoopVectorize.cpp use InstructionCost
David Sherwood via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 6 08:24:58 PST 2021
david-arm marked 4 inline comments as done.
david-arm added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7267
+ "Invalid vector call or intrinsic cost");
+ return InstructionCost::min(CallCost, IntrinsicCost);
+ }
----------------
ctetreau wrote:
> I mentioned it in another patch, but I'm wondering if InstructionCost::min is a neccesary function. I think std::min will work.
>
> Should we get rid of InstructionCost::min and InstructionCost::max?
Hi @ctetreau, I'll create a separate patch to remove the min/max functions, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94065/new/
https://reviews.llvm.org/D94065
More information about the llvm-commits
mailing list