[PATCH] D93337: AMDGPU/GlobalISel: Start cleaning up calling convention lowering

Christudasan Devadasan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 05:12:43 PST 2021


cdevadas added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp:261
     const LLT RegTy = MRI.getType(ValVReg);
-    if (RegTy.getSizeInBytes() > Size)
-      Size = RegTy.getSizeInBytes();
-
-    assignValueToAddress(ValVReg, Addr, Size, MPO, VA);
+    MemSize = std::min(MemSize, (uint64_t)RegTy.getSizeInBytes());
+    assignValueToAddress(ValVReg, Addr, MemSize, MPO, VA);
----------------
Why did you change the condition here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93337/new/

https://reviews.llvm.org/D93337



More information about the llvm-commits mailing list