[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

Jan Svoboda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 6 04:41:33 PST 2021


jansvoboda11 added a comment.

@thakis Thanks for the heads-up and sorry for the inconvenience.

@rnk You're right. This patch accidentally changed `Group<g_flags_Group>` to `Group<g_Group>` for  `-g[no-]column-info`. In the linked build, this caused expansion of the driver flag `-gcolumn-info` to cc1 flag `-debug-info-kind=limited` instead of the correct `-debug-info-kind=tables-only`.

I've fixed the `Group` for `-g[no-]column-info` and for other two flags that were affected in a similar way in. https://reviews.llvm.org/rGce8c59e6af487f0b8786ae921aa926341f0ae04f

Let me know if there are any outstanding issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83892/new/

https://reviews.llvm.org/D83892



More information about the llvm-commits mailing list