[PATCH] D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 6 01:38:15 PST 2021
phosek added a comment.
This is fine with me, but I wonder we should avoid setting this property for every target and instead rely on `CMAKE_BUILD_WITH_INSTALL_RPATH` (we could set `CMAKE_BUILD_WITH_INSTALL_RPATH` to `ON` if unset to preserve the current behavior).
================
Comment at: llvm/cmake/modules/AddLLVM.cmake:870-878
+ if("${CMAKE_BUILD_RPATH}" STREQUAL "")
+ set(build_with_install ON)
+ else()
+ set(build_with_install OFF)
+ endif()
+
set_target_properties(${name} PROPERTIES
----------------
You could also consider something like this to avoid the extra variable (the same below).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93177/new/
https://reviews.llvm.org/D93177
More information about the llvm-commits
mailing list