[PATCH] D94088: [SCEV] Assumption context for GetMinTrailingZeros

[Gil Rapaport via Phabricator via llvm-commits]

gilr added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:6893
+               (uint32_t)31,
+               GetMinTrailingZeros(TCExpr, L->getHeader()->getTerminator()));
 
----------------
fhahn wrote:
> Why use the header's terminator here?
No reason, actually. Will change to first instruction in the header.


================
Comment at: llvm/test/Transforms/LoopUnroll/runtime-unroll-assume-no-remainder.ll:7
+
+define dso_local void @assumeDivisibleTC(i8* noalias nocapture %a, i8* noalias nocapture readonly %b, i32 %n, i1 %c) local_unnamed_addr {
+; CHECK-LABEL: @assumeDivisibleTC(
----------------
fhahn wrote:
> I think it would be good to combine a few of those related tests in a single file :)
Ah, good catch on LV (but I better do this separately to keep this patch's changes clear).
(Unroller tests running roughly the same opt command seem to have manual CHECK lines. Not sure how well it would mix with automated CHECKs that need to be updated from time to time)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94088/new/

https://reviews.llvm.org/D94088