[PATCH] D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch.

EsmeYi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 23:21:20 PST 2021


Esme added a comment.

In D94054#2479070 <https://reviews.llvm.org/D94054#2479070>, @nemanjai wrote:

> It seems like this patch depends on another patch. Please don't forget to add the dependencies to the Phabricator reviews.

An NFC patch, this patch depends on, only committed test cases.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:4384
 
+static bool isTestSqrtOpcode(SDValue N) {
+  if (N.getOpcode() == PPCISD::FTSQRT)
----------------
nemanjai wrote:
> If the only possible use for these test nodes are to `and` the result with `1/2/4`, you might as well check the whole thing in this function.
> Otherwise, I think it's fine as-is.
> If the only possible use for these test nodes are to `and` the result with `1/2/4`, you might as well check the whole thing in this function.
> Otherwise, I think it's fine as-is.

Another pattern  (truncateToi1 SWTestOp) is added now, well, I can't find more possible patterns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94054/new/

https://reviews.llvm.org/D94054



More information about the llvm-commits mailing list