[PATCH] D92473: [Legalizer] Promote result type in expanding FP_TO_XINT

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 22:07:00 PST 2021


steven.zhang added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:1911
+  RTLIB::Libcall LC = findFPToIntLibcall(Op.getValueType(), RVT, NVT, Signed);
   assert(LC != RTLIB::UNKNOWN_LIBCALL && "Unsupported FP_TO_XINT!");
   TargetLowering::MakeLibCallOptions CallOptions;
----------------
Also add the assertion for NVT to make it more safe ? assert(NVT.isSimple() ...)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92473/new/

https://reviews.llvm.org/D92473



More information about the llvm-commits mailing list