[PATCH] D94118: [X86] ESP should not be in the regcall CSR list

[Pengfei Wang via Phabricator via llvm-commits]

pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/X86/X86CallingConv.td:1103
 
 // All GPRs - except r11
 def CSR_64_RT_MostRegs : CalleeSavedRegs<(add CSR_64, RAX, RCX, RDX, RSI, RDI,
----------------
rnk wrote:
> pengfei wrote:
> > except r11 and rsp?
> I don't think that adds any clarification. RSP is preserved, just like you would expect of any regular, non callee-cleanup convention.
Yeah, you are right. I don't know what are these definition used for. Just saw it says all GPRs :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94118/new/

https://reviews.llvm.org/D94118