[PATCH] D93943: [SimplifyCFG] Update SimplifyBranchOnICmpChain to recognize select form of and/or

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune added a comment.

In D93943#2476723 <https://reviews.llvm.org/D93943#2476723>, @nikic wrote:

> Thinking about this again, don't we need to always freeze the extra condition (unless known non-undef/poison)? While poison is only a problem when converting the select form into a branch, doesn't undef need to be frozen even in the and/or form? As the other operand may make it unconditionally true/false and thus well-defined.
>
> In that case, I think we should either always insert the freeze, or not inserted it in the select form either (your original patch) with a FIXME for the more general problem.

I'm fine with either direction. I'll update this to uninsert freeze and leave FIXME.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93943/new/

https://reviews.llvm.org/D93943