[PATCH] D93732: [LLD][COFF] When using PCH.OBJ, ensure func_id records indices are remapped under /DEBUG:GHASH

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

The Harbormaster precommit test stuff is complaining, but maybe it's just because of the binary files in the patch.



================
Comment at: lld/COFF/DebugTypes.cpp:1150-1153
 // Fill in a TPI or IPI index map using ghashes. For each source type, use its
 // ghash to lookup its final type index in the PDB, and store that in the map.
 void TpiSource::fillMapFromGHashes(GHashState *g,
                                    SmallVectorImpl<TypeIndex> &mapToFill) {
----------------
I think this is ripe for some follow-on simplifications. I believe `mapToFill` is always just `indexMapStorage`. This routine is really rewriting ghash cell indices to PDB type indices.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93732/new/

https://reviews.llvm.org/D93732