[PATCH] D91050: [NFC] Add the EmitTargetCodeForConstantPool hook for target to customize it with MachineConstantPoolValue

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 5 16:27:43 PST 2021


echristo added a comment.

In D91050#2480906 <https://reviews.llvm.org/D91050#2480906>, @steven.zhang wrote:

> Ping...

I really don't think this is the right interface for this, similar to what Nemanja said. In addition, the uses and needs of Alignment here are a little odd and I think need some more explanation. Can you elaborate on what you're trying to do here a bit more?

Thanks!

-eric


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91050/new/

https://reviews.llvm.org/D91050



More information about the llvm-commits mailing list